[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] qmp: Disable query-cpu-* commands when they'
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] qmp: Disable query-cpu-* commands when they're unavailable |
|
Date: |
Wed, 5 Oct 2016 14:52:20 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 10/05/2016 02:49 PM, Eduardo Habkost wrote:
> Instead of requiring clients to actually call the query-cpu-*
> commands to find out if they are implemented, remove them from
> the output of "query-commands", so clients know they are not
> available.
>
> This is implemented by extending the existing hack at
> qmp_unregister_commands_hack(). I wish I could avoid adding even
> more #ifdefs to that code, but that's the solution we have today.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> Changes v1 -> v2:
> * Instead of adding new qmp_commands_init() and
> arch_qmp_commands_init() functions, simply extend the hack at
> qmp_unregister_commands_hack()
> ---
> monitor.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature