Re: [Qemu-devel] [PATCH v4 13/35] tcg: Add atomic helpers

[Richard Henderson]

On 10/05/2016 04:17 AM, Alex Bennée wrote:
> /tmp/qemu-test/src/tcg/tcg-op.c:2296:255: error: 
> ‘gen_helper_atomic_xor_fetchl_be’ undeclared here (not in a function)
>
> Which makes me wonder in we should be including:
>
> #include "exec/helper-proto.h"
>
> And if this is generating all the prototypes it should.

No, there was a patch posted for this as well.  Hopefully that hasn't been lost 
as well, since the fix was more involved.  Something about the macro expansion 
on the non-__atomic path taken by gcc 4.2.

I had to test on centos 6 to see it myself.


r~