Re: [Qemu-devel] [PATCH v6 12/20] trace: don't abort qemu if ftrace can't be initialized

[Stefan Hajnoczi]

On Tue, Oct 04, 2016 at 03:12:31PM -0500, Eric Blake wrote:
> On 10/04/2016 08:35 AM, Daniel P. Berrange wrote:
> > If the ftrace backend is compiled into QEMU, any attempt
> > to start QEMU while non-root will fail due to the
> > inability to open /sys/kernel/debug/tracing/tracing_on.
> > 
> > Add a fallback into the code so that it connects up the
> > trace_marker_fd variable to /dev/null when setting
> 
> s/setting/getting/ ?
> 
> > EACCESS on the 'trace_on' file. This allows QEMU to
> 
> s/EACCESS/EACCES/

Thanks, I've applied these changes while merging.

Stefan

signature.asc
Description: PGP signature