[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Optimize L2 table cache siz
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Optimize L2 table cache size based on image and cluster sizes |
Date: |
Wed, 05 Oct 2016 16:57:57 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 04 Oct 2016 05:51:26 PM CEST, Max Reitz wrote:
>> At least giving users a way to skip the math would be an improvement.
>> Would you be okay with an explicitly-set option like
>> l2_cache_size=auto or =max that optimizes for performance at the
>> expense of memory?
>
> That (cache-size=max) is actually something Stefan Hajnoczi has
> proposed at KVM Forum 2015.
>
> I agree that implementing the formula in qemu's qcow2 driver itself
> makes sense and will help users; however, I do think it is appropriate
> to expect the user to pass cache-size=max if they need it.
Frank Myhr's suggestion (in bugzilla) is that we allow specifying a % of
the disk size, so
l2-cache-size=100% (that would be cache-size=max)
l2-cache-size=80%
...
https://bugzilla.redhat.com/show_bug.cgi?id=1377735#c3
Either one looks good to me. They would change however the data type of
'l2-cache-size' from int to string in BlockdevOptionsQcow2, can we
actually do that?
Berto
- [Qemu-devel] [PATCH] qcow2: Optimize L2 table cache size based on image and cluster sizes, Ed Swierk, 2016/10/04
- Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Optimize L2 table cache size based on image and cluster sizes, Alberto Garcia, 2016/10/04
- Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Optimize L2 table cache size based on image and cluster sizes, Ed Swierk, 2016/10/04
- Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Optimize L2 table cache size based on image and cluster sizes, Max Reitz, 2016/10/04
- Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Optimize L2 table cache size based on image and cluster sizes,
Alberto Garcia <=
- Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Optimize L2 table cache size based on image and cluster sizes, Max Reitz, 2016/10/05
- Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Optimize L2 table cache size based on image and cluster sizes, Alberto Garcia, 2016/10/05
- Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Optimize L2 table cache size based on image and cluster sizes, Max Reitz, 2016/10/05
- Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Optimize L2 table cache size based on image and cluster sizes, Alberto Garcia, 2016/10/06
- Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Optimize L2 table cache size based on image and cluster sizes, Kevin Wolf, 2016/10/05
[Qemu-devel] [PATCH v2] qcow2: Add cache-size=max option to optimize caches for performance, Ed Swierk, 2016/10/04