[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/3] qapi: return a 'missing parameter' error
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/3] qapi: return a 'missing parameter' error |
Date: |
Wed, 05 Oct 2016 16:40:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
The appended fixups are necessary to pass the tests from "[PATCH 2.5/3]
tests/test-qmp-input-strict: Cover missing struct members". Can squash
in on commit.
diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visitor.c
index 9b9b350..37a8e1f 100644
--- a/qapi/qmp-input-visitor.c
+++ b/qapi/qmp-input-visitor.c
@@ -376,11 +376,6 @@ static void qmp_input_type_any(Visitor *v, const char
*name, QObject **obj,
return;
}
- if (!qobj) {
- error_setg(errp, QERR_MISSING_PARAMETER, name ? name : "null");
- return;
- }
-
qobject_incref(qobj);
*obj = qobj;
}
@@ -391,7 +386,6 @@ static void qmp_input_type_null(Visitor *v, const char
*name, Error **errp)
QObject *qobj = qmp_input_get_object(qiv, name, true, errp);
if (!qobj) {
- error_setg(errp, QERR_MISSING_PARAMETER, name ? name : "null");
return;
}