Re: [Qemu-devel] [PATCH v4 25/35] target-i386: remove helper_lock()

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> From: "Emilio G. Cota" <address@hidden>
>
> It's been superseded by the atomic helpers.
>
> The use of the atomic helpers provides a significant performance and 
> scalability
> improvement. Below is the result of running the atomic_add-test 
> microbenchmark with:
>  $ x86_64-linux-user/qemu-x86_64 tests/atomic_add-bench -o 5000000 -r $r -n $n
> , where $n is the number of threads and $r is the allowed range for the 
> additions.
>
<snip>
>
> For master I stopped measuring master after 8 threads, because there is little
> point in measuring the well-known performance collapse of a contended lock.
>
> Signed-off-by: Emilio G. Cota <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>

Reviewed-by: Alex Bennée <address@hidden>

--
Alex Bennée