Re: [Qemu-devel] [PATCH 0/3] RDMA error handling

[Dr. David Alan Gilbert]

* Juan Quintela (address@hidden) wrote:
> "Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> >
> > lp: https://bugs.launchpad.net/qemu/+bug/1545052
> >
> > The RDMA code tends to hang if the destination dies
> > in the wrong place;  this series doesn't completely fix
> > that, but in cases where the destination knows there's
> > been an error, it makes sure it tells the source and
> > that cleans up quickly.
> > If the destination just dies, then the source still hangs
> > and I still need to look at better ways to fix that.
> >
> > Dave
> >
> > Dr. David Alan Gilbert (3):
> >   migration/rdma: Pass qemu_file errors across link
> >   migration: Make failed migration load set file error
> >   migration/rdma: Don't flag an error when we've been told about one
> >
> >  migration/rdma.c   |  9 ++++++++-
> >  migration/savevm.c | 19 ++++++++++++-------
> >  2 files changed, 20 insertions(+), 8 deletions(-)
> 
> 
> Reviewed-by: Juan Quintela <address@hidden>
> 
> and applied.
> 

Thanks.

> BTW, second patch is not RDMA error handling O:-)

Ah, but it's there to cause the first patch to trigger.
It's not needed in the case of any of the other transports.

Dave

--
Dr. David Alan Gilbert / address@hidden / Manchester, UK