Re: [Qemu-devel] [PATCH 1/2] migration: report an error giving the failed field

[Juan Quintela]

"Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> When a field fails to load (typically due to a limit
> check, or a call to a get/put) report the device and field
> to give an indication of the cause.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
>  migration/vmstate.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/migration/vmstate.c b/migration/vmstate.c
> index fc29acf..1d637b2 100644
> --- a/migration/vmstate.c
> +++ b/migration/vmstate.c
> @@ -130,6 +130,8 @@ int vmstate_load_state(QEMUFile *f, const 
> VMStateDescription *vmsd,
>                  }
>                  if (ret < 0) {
>                      qemu_file_set_error(f, ret);
> +                    error_report("Failed to load %s:%s", vmsd->name,
> +                                 field->name);
>                      trace_vmstate_load_field_error(field->name, ret);
>                      return ret;
>                  }

Applied, thanks.