Re: [Qemu-devel] [PATCH 1/2] accel: allows to select the "best" accelerator

[Daniel P. Berrange]

On Tue, Oct 04, 2016 at 01:30:47PM +0200, Laurent Vivier wrote:
> By default, QEMU uses 'tcg' or the one provided with the "accel"
> property.
> 
> But sometime, user wants to use a real accelerator without knowing
> if he really can, with, for instance accel=kvm:tcg.
> In this case, and if the accelerator is not available we
> have a noisy "XXX accelerator not found".

IMHO it would be better to just remove that warning message
and continue using existing accel=kvm:tcg syntax to specify
the preference of which accelerators to use.

Only emit "XXX accelerator not found", if there are not
further accelerators listed. eg

  accel=kvm:tcg

should not print a "KVM accelerator not found" warning
when it falls back to tcg, but a

  accel=kvm

would print a warning, since no fallback is given.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|