Re: [Qemu-devel] [PATCH v4 00/13] virtio-crypto: introduce framework and device emulation

[Stefan Hajnoczi]

On Wed, Sep 28, 2016 at 04:25:39PM +0800, Gonglei wrote:
> The virtio crypto is a virtual crypto device as well as a kind
> of virtual hardware accelerator for virtual machines. The
> encryption and decryption requests are placed in the data
> queue and handled by the real crypto accelerators finally.
> The second queue is the control queue used to create or
> destroy sessions for symmetric algorithms and control
> some advanced features in the future. The virtio crypto
> device provides the following crypto services: CIPHER,
> MAC, HASH, AEAD etc.

Please look at my reply to the virtio-crypto spec email thread.  Changes
to the request layout are necessary (dropping custom scatter-gather I/O,
avoiding assumptions about iovec layout, ordering of
device-readable/writable buffers).

This will change the code quite a bit so I won't review further for now.

Stefan

signature.asc
Description: PGP signature