Re: [Qemu-devel] [PATCH v5 16/20] trace: get rid of generated-events.h/generated-events.c

[Stefan Hajnoczi]

On Wed, Sep 28, 2016 at 02:08:19PM +0100, Daniel P. Berrange wrote:
> Currently the generated-events.[ch] files contain the
> event dstates, constants and TraceEvent structs, while the
> generated-tracers.[ch] files contain the actual trace
> probe logic. With the removal of usage of the event enums
> from the API there is no longer any compelling reason for
> the separation between these files. The generated-events.h
> content is only ever needed from the generated-tracers.[ch]
> files.
> 
> The enums/constants/structs from generated-events.[ch] are
> thus moved into the generated-tracers.[ch], so that there
> is one less file to be generated.
> 
> Reviewed-by: Lluís Vilanova <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  Makefile                             |  3 --
>  include/trace-tcg.h                  |  1 -
>  include/trace.h                      |  1 -
>  scripts/tracetool/format/c.py        | 50 ++++++++++++++++++++++++++---
>  scripts/tracetool/format/events_c.py | 62 
> ------------------------------------
>  scripts/tracetool/format/events_h.py | 49 ----------------------------
>  scripts/tracetool/format/h.py        | 20 ++++++++++++
>  trace/Makefile.objs                  | 28 +++-------------
>  trace/control.h                      |  2 +-
>  trace/simple.h                       |  4 ---
>  10 files changed, 70 insertions(+), 150 deletions(-)
>  delete mode 100644 scripts/tracetool/format/events_c.py
>  delete mode 100644 scripts/tracetool/format/events_h.py

Reviewed-by: Stefan Hajnoczi <address@hidden>

signature.asc
Description: PGP signature