Re: [Qemu-devel] kvm test warnings

[Thomas Huth]

On 29.09.2016 17:16, Laurent Vivier wrote:
> 
> 
> On 09/09/2016 23:31, Michael S. Tsirkin wrote:
>> On Fri, Sep 09, 2016 at 09:24:45PM +0200, Thomas Huth wrote:
>>> On 09.09.2016 21:03, Michael S. Tsirkin wrote:
>>>> I am running make test on a box without kvm, and I am seeing these 
>>>> warnings:
>>>>
>>>> GTESTER check-qtest-ppc64
>>>> "kvm" accelerator not found.
>>>> "kvm" accelerator not found.
>>>> GTESTER check-qtest-x86_64
>>>> Could not access KVM kernel module: No such file or directory
>>>> failed to initialize KVM: No such file or directory
>>>> Back to tcg accelerator.
>>>> Could not access KVM kernel module: No such file or directory
>>>> failed to initialize KVM: No such file or directory
>>>> Back to tcg accelerator.
>>>>
>>>> This is with
>>>> commit c2a57aae9a1c3dd7de77daf5478df10379aeeebf
>>>> Merge: 5f31bbf f8042de
>>>> Author: Peter Maydell <address@hidden>
>>>> Date:   Fri Sep 9 12:49:41 2016 +0100
>>>>
>>>> I originally thought this is due to Marcel's test change,
>>>> but it triggers without ask well.
>>>>
>>>> Help will be appreciated.
>>>
>>> See this thread here:
>>>
>>> https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg05809.html
>>>
>>> It's not so easy to avoid this warning ... suggestions are welcome...
>>>
>>>  Thomas
>>
>>
>> Really, we just need to add a command line argument
>> "--suppress-test-warnings" and pass it in from test framework.
>>
> 
> What do you think of only displaying the error on the last accelerator
> of the list?
> 
> --- a/accel.c
> +++ b/accel.c
> @@ -99,7 +99,12 @@ void configure_accelerator(MachineState *ms)
>          p = get_opt_name(buf, sizeof(buf), p, ':');
>          acc = accel_find(buf);
>          if (!acc) {
> -            fprintf(stderr, "\"%s\" accelerator not found.\n", buf);
> +            if (*p != ':') {
> +                /* to avoid to pollute logs, display error only
> +                 * on the last accelerator of the list
> +                 */
> +                fprintf(stderr, "\"%s\" accelerator not found.\n", buf);
> +            }
>              continue;
>          }
>          if (acc->available && !acc->available()) {
> 
> The accelerator list can be seen as a failover list, so I don't think we
> have to display an error in this case as it is the expected behavior.

Sounds reasonable to me.

 Thomas