[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] xen: add qemu device for each pvusb backend
From: |
Juergen Gross |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] xen: add qemu device for each pvusb backend |
Date: |
Thu, 29 Sep 2016 16:49:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 27/09/16 11:08, Gerd Hoffmann wrote:
> Hi,
>
>> struct usbback_info {
>> struct XenDevice xendev; /* must be first */
>> + char id[24];
>> + struct USBBACKDevice *dev;
>> USBBus bus;
>> void *urb_sring;
>> void *conn_sring;
>> @@ -116,6 +124,10 @@ struct usbback_info {
>> QEMUBH *bh;
>> };
>>
>> +typedef struct USBBACKDevice {
>> + DeviceState qdev;
>> +} USBBACKDevice;
>
> Hmm, I think the xen core needs better QOM support ...
>
> struct XenDevice should have a DeviceState element, so it can be used as
> device object directly instead of attaching a device object like
> this ...
Hmm, interesting idea. The device object could even be added in
Xen common code if the backend is indicating the need for it via a
special flag/field. I'll have a try.
Juergen
Re: [Qemu-devel] [PATCH 0/2] Xen pvUSB correction, Gerd Hoffmann, 2016/09/27