[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/6] hypertrace: Lightweight guest-to-QEMU tr
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/6] hypertrace: Lightweight guest-to-QEMU trace channel |
Date: |
Wed, 28 Sep 2016 06:56:10 -0700 (PDT) |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v3 0/6] hypertrace: Lightweight guest-to-QEMU
trace channel
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/address@hidden -> patchew/address@hidden
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
7f152b3 hypertrace: Add guest-side Linux module
8ae8bbf hypertrace: Add guest-side user-level library
ae0f42a hypertrace: [softmmu] Add QEMU-side proxy to "guest_hypertrace" event
ef0849e hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event
a885493 hypertrace: Add tracing event "guest_hypertrace"
dbd698a hypertrace: Add documentation
=== OUTPUT BEGIN ===
Checking PATCH 1/6: hypertrace: Add documentation...
Checking PATCH 2/6: hypertrace: Add tracing event "guest_hypertrace"...
Checking PATCH 3/6: hypertrace: [*-user] Add QEMU-side proxy to
"guest_hypertrace" event...
ERROR: architecture specific defines should be avoided
#306: FILE: hypertrace/common.h:10:
+#if !defined(__KERNEL__)
total: 1 errors, 0 warnings, 831 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/6: hypertrace: [softmmu] Add QEMU-side proxy to
"guest_hypertrace" event...
Checking PATCH 5/6: hypertrace: Add guest-side user-level library...
ERROR: architecture specific defines should be avoided
#171: FILE: hypertrace/guest/user/common.c:83:
+#if !defined(CONFIG_USER_ONLY) && defined(__linux__)
ERROR: consider using qemu_strtoull in preference to strtoull
#191: FILE: hypertrace/guest/user/common.c:103:
+ uint64_t vv = strtoull(v, &res, 16);
total: 2 errors, 0 warnings, 428 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/6: hypertrace: Add guest-side Linux module...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH v3 0/6] hypertrace: Lightweight guest-to-QEMU trace channel, Lluís Vilanova, 2016/09/28
- [Qemu-devel] [PATCH v3 1/6] hypertrace: Add documentation, Lluís Vilanova, 2016/09/28
- [Qemu-devel] [PATCH v3 2/6] hypertrace: Add tracing event "guest_hypertrace", Lluís Vilanova, 2016/09/28
- [Qemu-devel] [PATCH v3 5/6] hypertrace: Add guest-side user-level library, Lluís Vilanova, 2016/09/28
- [Qemu-devel] [PATCH v3 3/6] hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event, Lluís Vilanova, 2016/09/28
- [Qemu-devel] [PATCH v3 4/6] hypertrace: [softmmu] Add QEMU-side proxy to "guest_hypertrace" event, Lluís Vilanova, 2016/09/28
- [Qemu-devel] [PATCH v3 6/6] hypertrace: Add guest-side Linux module, Lluís Vilanova, 2016/09/28
- Re: [Qemu-devel] [PATCH v3 0/6] hypertrace: Lightweight guest-to-QEMU trace channel,
no-reply <=