Re: [Qemu-devel] [PATCH v3 0/3] crypto: add ctr mode support and little inprovement

[Daniel P. Berrange]

On Tue, Sep 27, 2016 at 09:32:10AM +0000, Gonglei (Arei) wrote:
> Hi Daniel,
> 
> I'll post virtio-crypto v4 based on this patch set. 
> Would you please merge it if it's ok? Thanks.
> 
> Regards,
> -Gonglei
> 
> 
> > -----Original Message-----
> > From: Gonglei (Arei)
> > Sent: Monday, September 26, 2016 5:23 PM
> > To: address@hidden
> > Cc: address@hidden; Wubin (H); Gonglei (Arei)
> > Subject: [PATCH v3 0/3] crypto: add ctr mode support and little inprovement
> > 
> > Please see the detailed description in each patch.
> > 
> > v3:
> >  - adjust the sequence of patch 1 and 2. (Daniel)
> >  - fix a mising 'break' in code logic. (Daniel)
> > v2:
> >  - fix qtest complaint in cipher-builtin backend.
> >  - introduce patch 2 and patch 3.
> > 
> > Gonglei (3):
> >   crypto: extend mode as a parameter in qcrypto_cipher_supports()
> >   crypto: add CTR mode support
> >   crypto: add mode check in qcrypto_cipher_new() for cipher-builtin
> > 
> >  block/qcow.c               |  3 ++-
> >  block/qcow2.c              |  3 ++-
> >  crypto/cipher-builtin.c    | 25 +++++++++++++++++++-
> >  crypto/cipher-gcrypt.c     | 38 +++++++++++++++++++++++++------
> >  crypto/cipher-nettle.c     | 28 +++++++++++++++++++++--
> >  crypto/cipher.c            |  1 +
> >  include/crypto/cipher.h    | 12 ++++++----
> >  qapi/crypto.json           |  3 ++-
> >  tests/test-crypto-cipher.c | 57
> > +++++++++++++++++++++++++++++++++++++++++++++-
> >  ui/vnc.c                   |  2 +-
> >  10 files changed, 152 insertions(+), 20 deletions(-)

These 3 patches look good and pass my build tests, so I've added them
to my crypto queue.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|