qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] virtio-blk: add missing virtio_detach_eleme


From: Ladi Prosek
Subject: Re: [Qemu-devel] [PATCH 2/3] virtio-blk: add missing virtio_detach_element() call
Date: Tue, 27 Sep 2016 09:49:17 +0200

On Mon, Sep 19, 2016 at 3:28 PM, Stefan Hajnoczi <address@hidden> wrote:
> Make sure to unmap the scatter-gather list and decrement vq->inuse
> before freeing requests in virtio_blk_reset().
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  hw/block/virtio-blk.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
> index 3a6112f..c7ca4d6 100644
> --- a/hw/block/virtio-blk.c
> +++ b/hw/block/virtio-blk.c
> @@ -665,6 +665,7 @@ static void virtio_blk_reset(VirtIODevice *vdev)
>      while (s->rq) {
>          req = s->rq;
>          s->rq = req->next;
> +        virtqueue_detach_element(req->vq, &req->elem, 0);
>          virtio_blk_free_request(req);

Random observation. virtio_blk_free_request should be static and
removed from the header file. Or maybe removed altogether because
g_free takes NULL pointers just fine.

>      }
>
> --
> 2.7.4
>

Reviewed-by: Ladi Prosek <address@hidden>

Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]