[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/3] qapi: auto generate enum value strings
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/3] qapi: auto generate enum value strings |
Date: |
Mon, 26 Sep 2016 15:17:08 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/26/2016 05:38 AM, Daniel P. Berrange wrote:
> On Mon, Sep 26, 2016 at 06:16:26PM +0800, Lin Ma wrote:
>> Automatically generate enum value strings that containing the acceptable
>> values.
>> (Borrowwed Daniel's code.)
s/Borrowwed/Borrowed/
>>
>> Signed-off-by: Lin Ma <address@hidden>
>> ---
>> scripts/qapi-types.py | 2 ++
>> scripts/qapi.py | 9 +++++++++
>> 2 files changed, 11 insertions(+)
>
> This will need some test case coverage in tests/ somewhere, but I'm
> not sure exactly which place is best - Eric/Markus can probably advise
tests/test-qmp-commands.c is the first one that comes to mind, for
adding another test case to an existing program.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 0/3] object: Add 'help' option for all available backends and properties, Lin Ma, 2016/09/26
- [Qemu-devel] [PATCH v3 1/3] qom: make base type user-creatable abstract, Lin Ma, 2016/09/26
- [Qemu-devel] [PATCH v3 2/3] qapi: auto generate enum value strings, Lin Ma, 2016/09/26
- [Qemu-devel] [PATCH v3 3/3] object: Add 'help' option for all available backends and properties, Lin Ma, 2016/09/26
- Re: [Qemu-devel] [PATCH v3 0/3] object: Add 'help' option for all available backends and properties, no-reply, 2016/09/26
- Re: [Qemu-devel] [PATCH v3 0/3] object: Add 'help' option for all available backends and properties, Paolo Bonzini, 2016/09/26