Re: [Qemu-devel] [PULL 00/44] ppc-for-2.8 queue 20160922

[Alex Bennée]

David Gibson <address@hidden> writes:

> On Fri, Sep 23, 2016 at 08:42:22AM +0100, Alex Bennée wrote:
>>
>> David Gibson <address@hidden> writes:
>>
>> > On Thu, Sep 22, 2016 at 03:03:50PM +0100, Peter Maydell wrote:
>> >> On 22 September 2016 at 07:36, David Gibson <address@hidden> wrote:
>> >> > The following changes since commit 
>> >> > a008535b9fa396226ff9cf78b8ac5f3584bda58e:
>> >> >
>> >> >   build-sys: fix make install regression (2016-09-20 11:32:43 +0100)
>> >> >
>> >> > are available in the git repository at:
>> >> >
>> >> >   git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20160922
>> >> >
>> >> > for you to fetch changes up to 2832da4b6fc549d5feb2cf9fe53ad98cee894327:
>> >> >
>> >> >   monitor: fix crash for platforms without a CPU 0 (2016-09-22 15:53:01 
>> >> > +1000)
>> >> >
>> >> > ----------------------------------------------------------------
>> >> > ppc patch queue 2016-09-22
>> >> >
>> >> > This is my second pull request of ppc and spapr related patches for
>> >> > qemu-2.8.  Included here are
>> >> >     * TCG implementations for more POWER9 instructions
>> >> >     * Some preliminary XICS fixes in preparataion for the pnv machine 
>> >> > type
>> >> >     * A significant ADB (Macintosh kbd/mouse) cleanup
>> >> >     * Some conversions to use trace instead of debug macros
>> >> >     * Fixes to correctly handle global TLB flush synchronization in
>> >> >       TCG.  This is already a bug, but it will have much more impact
>> >> >       when we get MTTCG
>> >> >     * Add more qtest testcases for Power
>> >> >     * Some MAINTAINERS updates
>> >> >     * Assorted bugfixes
>> >> >
>> >> > This touches some test files and monitor.c which are technically
>> >> > outside the ppc code, but coming through this tree because the changes
>> >> > are primarily of interest to ppc.
>> >> >
>> >> > ----------------------------------------------------------------
>> >>
>> >> I'm afraid this fails to build with clang:
>> >>
>> >> /home/petmay01/linaro/qemu-for-merges/target-ppc/translate.c:532:16:
>> >> error: unused function 'L' [-Werro
>> >> r,-Wunused-function]
>> >> EXTRACT_HELPER(L, 16, 2);
>> >>                ^
>> >> 1 error generated.
>> >
>> > Drat, I wonder why travis didn't catch that for me.
>>
>> Maybe a version thing? I've got a patch in flight for building with the
>> ThreadSanitizer which threw up some compiler warnings but that uses GCC.
>> Maybe a more recent clang build should be added as well?
>
> That'd be nice if possible .  However, I think we're restricted to
> what's in the not terribly up-to-date Ubuntu image that Travis uses
> for its containers, so we might not be able to get something new
> enough to trip this warning.

The base containers are 12.04 but there is a Trusty VM and for the
ThreadSanitizer patches I added the Ubuntu Toolchain PPA which is fairly
upto date.

--
Alex Bennée