Re: [Qemu-devel] [PATCH 1/7] target-i386: Move feature name arrays inside FeatureWordInfo

[Richard Henderson]

On 09/23/2016 12:45 PM, Eduardo Habkost wrote:
> It makes it easier to guarantee the arrays are the right size,
> and to find information when looking at the code.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
>  target-i386/cpu.c | 370 +++++++++++++++++++++++++-----------------------------
>  1 file changed, 170 insertions(+), 200 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>

>  static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
>      [FEAT_1_EDX] = {
> -        .feat_names = feature_name,
> +        .feat_names = {
> +            "fpu", "vme", "de", "pse",
> +            "tsc", "msr", "pae", "mce",
> +            "cx8", "apic", NULL, "sep",
> +            "mtrr", "pge", "mca", "cmov",
> +            "pat", "pse36", "pn" /* Intel psn */, "clflush" /* Intel clfsh */,
> +            NULL, "ds" /* Intel dts */, "acpi", "mmx",
> +            "fxsr", "sse", "sse2", "ss",
> +            "ht" /* Intel htt */, "tm", "ia64", "pbe",
> +        },

Unrelated, but can we make this feature_word_info structure const?  It may 
require the addition of const to other function parameters, in which case the 
change should be a separate patch.


r~