qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 07/14] pc: apic_common: extend APIC ID proper


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 07/14] pc: apic_common: extend APIC ID property to 32bit
Date: Thu, 22 Sep 2016 18:16:47 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0


On 22/09/2016 18:00, Igor Mammedov wrote:
> > Why not just return initial_apic_id?  This is the meaning the property
> > had before your patch.
> 
> initial_apic_id is immutable but 'id' could be changed at runtime by guest in 
> xAPIC mode
> so returned value depends on xAPIC/x2APIC mode

Understood, but this is just a possibly poorly-named property.  "id"
(e.g. from info qtree as opposed to info lapic) used to be the initial
APIC ID always, even in x2APIC mode.

Not a big deal, but thought I'd mention it since you can keep using
static properties.

Paolo

> so I'm just following spec here.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]