Re: [Qemu-devel] [RFC PATCH v2 07/16] hmp: display memory encryption support in 'info kvm'

[Eric Blake]

On 09/22/2016 09:52 AM, Brijesh Singh wrote:
> update 'info kvm' to display the memory encryption support.
> 
> (qemu) info kvm
> kvm support: enabled
> memory encryption: disabled
> 
> Signed-off-by: Brijesh Singh <address@hidden>
> ---

> +++ b/qapi-schema.json
> @@ -99,9 +99,12 @@
>  #
>  # @present: true if KVM acceleration is built into this executable
>  #
> -# Since: 0.14.0
> +# @mem_encryption: true if Memory Encryption is active
> +#
> +# Since: 2.8.0

Not quite right.  The KvmInfo struct is still since 0.14.0, only the
mem_encryption member is new.  And new members should be spelled with
'-' rather than '_', if there is no other '_' in the struct.

So you want:

# @present: true if KVM acceleration is built into this executable
#
# @mem-encryption: true if Memory Encryption is active (since 2.8)
#
# Since: 0.14.0

>  ##
> -{ 'struct': 'KvmInfo', 'data': {'enabled': 'bool', 'present': 'bool'} }
> +{ 'struct': 'KvmInfo', 'data': {'enabled': 'bool', 'present': 'bool',
> +            'mem_encryption' : 'bool'} }

and with the corresponding spelling fix here.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature