Re: [Qemu-devel] [PULL 00/26] linux-user update

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 00/26] linux-user update

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
c530452 linux-user: fix TARGET_NR_select
c96fe2f linux-user: Fix incorrect offset of tuc_stack in ARM 
do_sigframe_return_v2
b593958 linux-user: Sanity check clone flags
153487c linux-user: Remove unnecessary nptl_flags variable from do_fork()
401280d linux-user: Implement force_sigsegv() via force_sig()
f4521bb linux-user: SIGSEGV from sigreturn need not be fatal
6d101e2 linux-user: ARM: Give SIGSEGV if signal frame setup fails
5216a3a linux-user: SIGSEGV on signal entry need not be fatal
1bfdef8 linux-user: Pass si_type information to queue_signal() explicitly
5703d87 linux-user: Recheck for pending synchronous signals too
34fc16a linux-user: ppc64: set MSR_CM bit for BookE 2.06 MMU
febbc63 linux-user: Use correct target SHMLBA in shmat()
894d8ae linux-user: Use glib malloc functions in load_symbols()
0181e3e linux-user: Check dump_write() return in elf_core_dump()
95f7091 linux-user: Fix error handling in flatload.c target_pread()
07748da linux-user: Fix incorrect use of host errno in do_ioctl_dm()
03f4c78 linux-user: Check lock_user() return value for NULL
d3d5c63 linux-user: Pass missing MAP_ANONYMOUS to target_mmap() call
e3b270d linux-user: report signals being taken in strace output
bce0802 linux-user: Range check the nfds argument to ppoll syscall
96e1e0e linux-user: Check for bad event numbers in epoll_wait
caba33f linux-user: Use direct syscall for utimensat
4050f40 linux-user: Implement FS_IOC_GETFLAGS and FS_IOC_SETFLAGS ioctls
a291b03 linux-user: Allow bad msg_name for recvfrom on connected socket
97a5a62 linux-user: Fix errno for sendrecvmsg with large iovec length
63b346f linux-user: Fix handling of iovec counts

=== OUTPUT BEGIN ===
Checking PATCH 1/26: linux-user: Fix handling of iovec counts...
Checking PATCH 2/26: linux-user: Fix errno for sendrecvmsg with large iovec 
length...
Checking PATCH 3/26: linux-user: Allow bad msg_name for recvfrom on connected 
socket...
Checking PATCH 4/26: linux-user: Implement FS_IOC_GETFLAGS and FS_IOC_SETFLAGS 
ioctls...
Checking PATCH 5/26: linux-user: Use direct syscall for utimensat...
ERROR: architecture specific defines should be avoided
#42: FILE: linux-user/syscall.c:523:
+#if defined(__NR_utimensat)

total: 1 errors, 0 warnings, 17 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/26: linux-user: Check for bad event numbers in epoll_wait...
Checking PATCH 7/26: linux-user: Range check the nfds argument to ppoll 
syscall...
Checking PATCH 8/26: linux-user: report signals being taken in strace output...
Checking PATCH 9/26: linux-user: Pass missing MAP_ANONYMOUS to target_mmap() 
call...
Checking PATCH 10/26: linux-user: Check lock_user() return value for NULL...
Checking PATCH 11/26: linux-user: Fix incorrect use of host errno in 
do_ioctl_dm()...
Checking PATCH 12/26: linux-user: Fix error handling in flatload.c 
target_pread()...
Checking PATCH 13/26: linux-user: Check dump_write() return in 
elf_core_dump()...
Checking PATCH 14/26: linux-user: Use glib malloc functions in load_symbols()...
Checking PATCH 15/26: linux-user: Use correct target SHMLBA in shmat()...
Checking PATCH 16/26: linux-user: ppc64: set MSR_CM bit for BookE 2.06 MMU...
Checking PATCH 17/26: linux-user: Recheck for pending synchronous signals too...
Checking PATCH 18/26: linux-user: Pass si_type information to queue_signal() 
explicitly...
Checking PATCH 19/26: linux-user: SIGSEGV on signal entry need not be fatal...
Checking PATCH 20/26: linux-user: ARM: Give SIGSEGV if signal frame setup 
fails...
Checking PATCH 21/26: linux-user: SIGSEGV from sigreturn need not be fatal...
Checking PATCH 22/26: linux-user: Implement force_sigsegv() via force_sig()...
Checking PATCH 23/26: linux-user: Remove unnecessary nptl_flags variable from 
do_fork()...
Checking PATCH 24/26: linux-user: Sanity check clone flags...
Checking PATCH 25/26: linux-user: Fix incorrect offset of tuc_stack in ARM 
do_sigframe_return_v2...
Checking PATCH 26/26: linux-user: fix TARGET_NR_select...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden