Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

[Markus Armbruster]

"Daniel P. Berrange" <address@hidden> writes:

> On Wed, Sep 21, 2016 at 01:18:58PM -0500, Eric Blake wrote:
>> On 09/21/2016 10:28 AM, Markus Armbruster wrote:
>> 
>> >> The compiler.h file has no license header, just a comment
>> >> saying "public domain", which is obviously not the case
>> >> if you add this macro.
>> >>
>> >> Given that you'll need to explicitly mention the license terms
>> >> for ignore_value. eg with a comment line like
>> >>
>> >>   /* The ignore_value() macro is taken from GNULIB ignore-value.h,
>> >>    * licensed under the terms of the LGPLv2+
>> >>    */
>> > 
>> > Our tree has a mix of licenses, which is enough of a pain.  Mixing
>> > licenses within *files* is even worse, and might not even be legally
>> > sound.
>> > 
>> > Relicense the whole file under our preferred license GPLv2+?
>> 
>> That works too.  No one can legally complain - the current license is so
>> permissive that marking the entire file LGPLv2+ is permitted by the
>> current license.  It's a one-way conversion (we can't go back once we do
>> it), but I would be fine with that approach.
>
> I think the file probably should not have been listed as public domain
> in the first place, as its initial contents were copied from qemu-common.h
> which is not public domain.

Ewww!  Needs fixing.

Since qemu-common.h carries no license, GPLv2+ applies.