[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/10] block: Accept device model name for bl
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/10] block: Accept device model name for blockdev-open/close-tray |
Date: |
Mon, 19 Sep 2016 14:28:25 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/19/2016 11:54 AM, Kevin Wolf wrote:
> In order to remove the necessity to use BlockBackend names in the
> external API, we want to allow qdev device names in all device related
> commands.
>
> This converts blockdev-open/close-tray to accept a qdev device name.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> blockdev.c | 61
> +++++++++++++++++++++++++++++++++++++++-------------
> qapi/block-core.json | 14 ++++++++----
> qmp-commands.hx | 16 ++++++++------
> 3 files changed, 66 insertions(+), 25 deletions(-)
>
> +++ b/qmp-commands.hx
> @@ -4295,7 +4295,7 @@ EQMP
>
> {
> .name = "blockdev-open-tray",
> - .args_type = "device:s,force:b?",
> + .args_type = "device:s?,id:s?,force:b?",
> .mhandler.cmd_new = qmp_marshal_blockdev_open_tray,
> },
Let the merge conflicts begin! Commit 33e1666b has landed.
> @@ -4329,7 +4331,7 @@ Arguments:
> Example:
>
> -> { "execute": "blockdev-open-tray",
> - "arguments": { "device": "ide1-cd0" } }
> + "arguments": { "id": "ide0-1-0" } }
The changes to the examples look good. Overall, I'm fine with:
Reviewed-by: Eric Blake <address@hidden>
but I'm afraid it may be easiest for you to respin v3 and do the rebase
work here and elsewhere in the series.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/10] block: Accept qdev IDs in device level QMP commands, Kevin Wolf, 2016/09/19
- [Qemu-devel] [PATCH v2 02/10] qdev-monitor: Factor out find_device_state(), Kevin Wolf, 2016/09/19
- [Qemu-devel] [PATCH v2 01/10] block: Add blk_by_dev(), Kevin Wolf, 2016/09/19
- [Qemu-devel] [PATCH v2 04/10] block: Accept device model name for blockdev-open/close-tray, Kevin Wolf, 2016/09/19
- Re: [Qemu-devel] [PATCH v2 04/10] block: Accept device model name for blockdev-open/close-tray,
Eric Blake <=
- [Qemu-devel] [PATCH v2 03/10] qdev-monitor: Add blk_by_qdev_id(), Kevin Wolf, 2016/09/19
- [Qemu-devel] [PATCH v2 05/10] block: Accept device model name for x-blockdev-insert-medium, Kevin Wolf, 2016/09/19
- [Qemu-devel] [PATCH v2 06/10] block: Accept device model name for x-blockdev-remove-medium, Kevin Wolf, 2016/09/19
- [Qemu-devel] [PATCH v2 08/10] block: Accept device model name for blockdev-change-medium, Kevin Wolf, 2016/09/19
- [Qemu-devel] [PATCH v2 07/10] block: Accept device model name for eject, Kevin Wolf, 2016/09/19
- [Qemu-devel] [PATCH v2 09/10] block: Accept device model name for block_set_io_throttle, Kevin Wolf, 2016/09/19