[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 5/7] linux-user: Fix certain argument alignme
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v6 5/7] linux-user: Fix certain argument alignment cases for Mips64 |
Date: |
Fri, 16 Sep 2016 21:29:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
Le 16/09/2016 à 13:14, Aleksandar Markovic a écrit :
> From: Aleksandar Markovic <address@hidden>
>
> The function that is changed in this patch is supposed to indicate that
> there was certaing argument rearangement related to 64-bit arguments on
> 32-bit platforms. The background on such rearangements can be found,
> for example, in the man page for syscall(2).
>
> However, for 64-bit Mips architectures there is no such rearangement,
> and this patch reflects it.
>
> Signed-off-by: Aleksandar Rikalo <address@hidden>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
> linux-user/syscall.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index ca06943..ee23b29 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -620,7 +620,14 @@ static inline int regpairs_aligned(void *cpu_env) {
> return ((((CPUARMState *)cpu_env)->eabi) == 1) ;
> }
> #elif defined(TARGET_MIPS)
> -static inline int regpairs_aligned(void *cpu_env) { return 1; }
> +static inline int regpairs_aligned(void *cpu_env)
> +{
> +#if TARGET_ABI_BITS == 32
> + return 1;
> +#else
> + return 0;
> +#endif
> +}
> #elif defined(TARGET_PPC) && !defined(TARGET_PPC64)
> /* SysV AVI for PPC32 expects 64bit parameters to be passed on odd/even pairs
> * of registers which translates to the same as ARM/MIPS, because we start
> with
>
To mimic PPC, would be cleaner with:
...
#elif defined(TARGET_MIPS) && TARGET_ABI_BITS == 32
static inline int regpairs_aligned(void *cpu_env) { return 1; }
#else
...
Laurent
- Re: [Qemu-devel] [PATCH v6 1/7] linux-user: Fix TARGET_SIOCATMARK definition for Mips, (continued)
- [Qemu-devel] [PATCH v6 2/7] linux-user: Fix TARGET_F_GETOWN definition for Mips, Aleksandar Markovic, 2016/09/16
- [Qemu-devel] [PATCH v6 3/7] linux-user: Fix structure target_flock definition for Mips, Aleksandar Markovic, 2016/09/16
- [Qemu-devel] [PATCH v6 4/7] linux-user: Fix structure target_semid64_ds definition for Mips, Aleksandar Markovic, 2016/09/16
- [Qemu-devel] [PATCH v6 5/7] linux-user: Fix certain argument alignment cases for Mips64, Aleksandar Markovic, 2016/09/16
- Re: [Qemu-devel] [PATCH v6 5/7] linux-user: Fix certain argument alignment cases for Mips64,
Laurent Vivier <=
- [Qemu-devel] [PATCH v6 6/7] linux-user: Add missing TARGET_EDQUOT error code for Mips, Aleksandar Markovic, 2016/09/16
- [Qemu-devel] [PATCH v6 7/7] linux-user: Add missing Mips syscalls items in strace.list, Aleksandar Markovic, 2016/09/16