Re: [Qemu-devel] [PATCH v11 0/6] QAPI/QOM work for non-scalar object properties

[Daniel P. Berrange]

On Wed, Sep 14, 2016 at 05:04:05PM +0200, Kevin Wolf wrote:
> Am 05.09.2016 um 17:16 hat Daniel P. Berrange geschrieben:
> > This patch series contains only the QAPI/QOM bits of my previous
> > access control patch series:
> > 
> >  v1: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg04618.html
> >  v2: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg01454.html
> >  v3: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg02498.html
> >  v4: https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg01661.html
> >  v5: https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg00485.html
> >  v6: https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg03876.html
> >  v7: https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg00919.html
> >  v8: https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg03115.html
> >  v9: https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg02653.html
> >  v10: https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg02694.html
> > 
> > This series provides the infrastructure to allow use of non-scalar
> > properties with the -object CLI arg, and object_add monitor commands.
> > eg a property which is a list of structs. The syntax used for this is
> > intentionally compatible with the syntax used by the block layer. This
> > will allow the qdict_crumple method to be used by the block layer to
> > convert from QemuOpts into structured QAPI block layer structs at a
> > future date. It is already used by one of Max's patch series, and
> > recent patches for glusterfs multiple-host support could have made
> > use of it to simplify code.
> 
> I haven't looked at the final patch because that one is irrelevant for
> me, but otherwise nice series.
> 
> Please keep me copied on new versions of it, I noticed that
> qdict_crumple() and qobject_string_visitor_new() are exactly what I need
> for implementing the new '-blockdev' option, so I'll build on top of
> this.

That's entirely intentional :-)

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|