[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/5] usb:xhci:fix memory leak in usb_xhci_exit
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 3/5] usb:xhci:fix memory leak in usb_xhci_exit |
Date: |
Wed, 14 Sep 2016 11:33:33 +0200 |
From: Li Qiang <address@hidden>
If the xhci uses msix, it doesn't free the corresponding
memory, thus leading a memory leak. This patch avoid this.
Signed-off-by: Li Qiang <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/usb/hcd-xhci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 37c1493..726435c 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -3715,8 +3715,7 @@ static void usb_xhci_exit(PCIDevice *dev)
/* destroy msix memory region */
if (dev->msix_table && dev->msix_pba
&& dev->msix_entry_used) {
- memory_region_del_subregion(&xhci->mem, &dev->msix_table_mmio);
- memory_region_del_subregion(&xhci->mem, &dev->msix_pba_mmio);
+ msix_uninit(dev, &xhci->mem, &xhci->mem);
}
usb_bus_release(&xhci->bus);
--
1.8.3.1
- [Qemu-devel] [PULL 0/5] usb: large file support for mtp, bugfixes., Gerd Hoffmann, 2016/09/14
- [Qemu-devel] [PULL 3/5] usb:xhci:fix memory leak in usb_xhci_exit,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 1/5] xhci: Fix remainder field for TR_SETUP completion event., Gerd Hoffmann, 2016/09/14
- [Qemu-devel] [PULL 2/5] usb-host: fix streams detection in usb_host_speed_compat, Gerd Hoffmann, 2016/09/14
- [Qemu-devel] [PULL 4/5] usb-mtp: fix sending files larger than 4gb, Gerd Hoffmann, 2016/09/14
- [Qemu-devel] [PULL 5/5] usb-mtp: added object properties, Gerd Hoffmann, 2016/09/14
- Re: [Qemu-devel] [PULL 0/5] usb: large file support for mtp, bugfixes., Peter Maydell, 2016/09/15