[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/15] crypto: add cryptoLegacyHW stuff
From: |
Gonglei (Arei) |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/15] crypto: add cryptoLegacyHW stuff |
Date: |
Tue, 13 Sep 2016 10:14:54 +0000 |
> -----Original Message-----
> From: Daniel P. Berrange [mailto:address@hidden
> Sent: Tuesday, September 13, 2016 6:09 PM
> To: Gonglei (Arei)
> Subject: Re: [PATCH v2 03/15] crypto: add cryptoLegacyHW stuff
>
> On Tue, Sep 13, 2016 at 10:05:01AM +0000, Gonglei (Arei) wrote:
> >
> >
> > > -----Original Message-----
> > > From: Daniel P. Berrange [mailto:address@hidden
> > > Sent: Tuesday, September 13, 2016 5:23 PM
> > > To: Gonglei (Arei)
> > > Cc: address@hidden; address@hidden; Huangpeng
> > > (Peter); Luonengjun; address@hidden; address@hidden;
> > > address@hidden; Huangweidong (C); address@hidden;
> > > address@hidden; address@hidden; Claudio Fontana; address@hidden;
> > > address@hidden
> > > Subject: Re: [PATCH v2 03/15] crypto: add cryptoLegacyHW stuff
> > >
> > > On Tue, Sep 13, 2016 at 11:52:09AM +0800, Gonglei wrote:
> > > > In previous patch, we define CryptoLegacyHWOptions in
> > > > qapi-schema.json. we introduce the new/delete funciton
> > > > about crypto legacy hardware device.
> > >
> > > Isn't virtio-crypto / cryptodev an entirely new specification ?
> >
> > Yes, it's an complete new device.
> >
> > > I'm surprised to be seeing something completely new described
> > > as "legacy". Can you explain this in more detail.
> > >
> > Because there are two kind of crypto device, one is virtio-crypto which is
> > a virtual crypto device (And virtio-crypto device is a real crypto device
> > seen by
> the guest).
> > The other is cryptodev backend device. I have no good idea to name the
> kind
> > of virtio-crypto device, so named to legacy crypto device refer to Net
> > stuff.
> >
> > Do you have any suggestion? Thanks!
>
> How about just calling it 'Backend' instead of 'Legacy' then ?
>
It sounds reasonable I think. Because the virtio specification usually say
The backend device.... and The frontend driver....
So let's:
s/cryptoLegacyHW/cryptoBackendHW/g
Regards,
-Gonglei
[Qemu-devel] [PATCH v2 02/15] crypto: introduce crypto queue handler, Gonglei, 2016/09/12
- Re: [Qemu-devel] [PATCH v2 02/15] crypto: introduce crypto queue handler, Daniel P. Berrange, 2016/09/13
- Re: [Qemu-devel] [PATCH v2 02/15] crypto: introduce crypto queue handler, Gonglei (Arei), 2016/09/13
- Re: [Qemu-devel] [PATCH v2 02/15] crypto: introduce crypto queue handler, Paolo Bonzini, 2016/09/13
- Re: [Qemu-devel] [virtio-dev] Re: [PATCH v2 02/15] crypto: introduce crypto queue handler, Ola Liljedahl, 2016/09/13
- Re: [Qemu-devel] [virtio-dev] Re: [PATCH v2 02/15] crypto: introduce crypto queue handler, Gonglei (Arei), 2016/09/13
- Re: [Qemu-devel] [virtio-dev] Re: [PATCH v2 02/15] crypto: introduce crypto queue handler, Ola Liljedahl, 2016/09/14
Re: [Qemu-devel] [virtio-dev] Re: [PATCH v2 02/15] crypto: introduce crypto queue handler, Gonglei (Arei), 2016/09/13
[Qemu-devel] [PATCH v2 09/15] virtio-crypto: add virtio crypto realization, Gonglei, 2016/09/12
[Qemu-devel] [PATCH v2 01/15] crypto: introduce cryptodev backend and crypto legacy hardware, Gonglei, 2016/09/12