[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] migrate: Fix bounds check for migration para
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH v4] migrate: Fix bounds check for migration parameters in migration.c |
Date: |
Tue, 13 Sep 2016 14:11:05 +0530 |
On (Sat) 10 Sep 2016 [02:43:17], Ashijeet Acharya wrote:
> This patch fixes the out-of-bounds check of migration parameters in
> qmp_migrate_set_parameters() for cpu-throttle-initial and
> cpu-throttle-increment by adding a return statement for both as they
> were broken since their introduction in 2.5 via commit 1626fee.
> Due to the missing return statements, parameters were getting set to
> out-of-bounds values despite the error.
>
> Signed-off-by: Ashijeet Acharya <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> Changes in v4:
> -Fix the typo in commit message
> -Include the commit id which caused the regression
OK - I acked v1, but this is a better commit message.
Reviewed-by: Amit Shah <address@hidden>
Amit