Re: [Qemu-devel] [PATCH v5 2/2] qdisk - hw/block/xen_disk: grant copy implementation

[Anthony PERARD]

On Tue, Aug 16, 2016 at 08:55:56AM +0200, Paulina Szubarczyk wrote:
> diff --git a/configure b/configure
> index 8d84919..68b3374 100755
> --- a/configure
> +++ b/configure
> @@ -1956,6 +1956,43 @@ EOF
>  /*
>   * If we have stable libs the we don't want the libxc compat
>   * layers, regardless of what CFLAGS we may have been given.
> + *
> + * Also, check if xengnttab_grant_copy_segment_t is defined and
> + * grant copy operation is implemented.
> + */
> +#undef XC_WANT_COMPAT_EVTCHN_API
> +#undef XC_WANT_COMPAT_GNTTAB_API
> +#undef XC_WANT_COMPAT_MAP_FOREIGN_API
> +#include <xenctrl.h>
> +#include <xenstore.h>
> +#include <xenevtchn.h>
> +#include <xengnttab.h>
> +#include <xenforeignmemory.h>
> +#include <stdint.h>
> +#include <xen/hvm/hvm_info_table.h>
> +#if !defined(HVM_MAX_VCPUS)
> +# error HVM_MAX_VCPUS not defined
> +#endif
> +int main(void) {
> +  xengnttab_handle *xg;
> +  xengnttab_grant_copy_segment_t* seg = NULL;
> +
> +  xg = xengnttab_open(0, 0);
> +  xengnttab_map_grant_ref(xg, 0, 0, 0);
> +  xengnttab_grant_copy(xg, 0, seg);
> +
> +  return 0;
> +}

I think we should check every interface that qemu use, for here that
just mean copy-paste the previous version check and add grant_copy to
it.


With that fix, I think the patch will be ready to go.

Thanks,

-- 
Anthony PERARD