Re: [Qemu-devel] [PATCH 09/12] cpus-common: always defer async_run_on_cpu work items

[Alex Bennée]

Paolo Bonzini <address@hidden> writes:

> async_run_on_cpu is only called from the I/O thread, not from CPU threads,
> so it doesn't make any difference.  It will make a difference however
> for async_safe_run_on_cpu.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  cpus-common.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/cpus-common.c b/cpus-common.c
> index 47f7c06..59c8dc8 100644
> --- a/cpus-common.c
> +++ b/cpus-common.c
> @@ -136,11 +136,6 @@ void async_run_on_cpu(CPUState *cpu, run_on_cpu_func 
> func, void *data)
>  {
>      struct qemu_work_item *wi;
>
> -    if (qemu_cpu_is_self(cpu)) {
> -        func(cpu, data);
> -        return;
> -    }
> -
>      wi = g_malloc0(sizeof(struct qemu_work_item));
>      wi->func = func;
>      wi->data = data;

Reviewed-by: Alex Bennée <address@hidden>

--
Alex Bennée