[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered |
Date: |
Tue, 30 Aug 2016 14:48:48 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 30/08/2016 13:31, Markus Armbruster wrote:
> $ for i in `git-ls-files`; do [ "`scripts/get_maintainer.pl -f
> --no-git-fallback $i | grep -v 'address@hidden'`" ] || echo $i; done
> >unmaintained-files
> $ grep -c '\.c$' unmaintained-files
> 402
>
> 402 out of 2132 (19%). More progress, but not yet there.
Not bad.
> $ git-diff --diff-filter=A --name-only 6138fbd | grep -c '\.c$'
> 215
> $ git-diff --diff-filter=A --name-only 6138fbd | grep '\.c$' | join
> unmaintained-files - | wc -l
> 86
>
> This time, it's 86 out of 215 (40%). Getting worse. I'll cook up a
> patch to make checkpatch.pl catch such additions.
Good idea.
>>>> Apparently, nobody cares for tests:
>>>>
>>>> $ grep '^tests/' unmaintained-files | grep -c '\.c$'
>>>> 654
>>>> $ git-ls-files | grep '^tests/' | grep -c '\.c$'
>>>> 664
>>>
>>> Now 91 out of 665.
>>
>> 105 out of 687.
>
> 114 out of 726.
I think this is expected to some extent. Is it worth moving tests to
many tests subdirectories, e.g. hw/scsi/tests? Many files would be
covered automatically.
> Active subsystems lacking a maintainer include tilegx, qdev, replay.
You, Eduardo, me?
> Headers that should probably be covered by existing MAINTAINERS stanzas
> include include/sysemu/block-backend.h include/qom/cpu.h
> include/hw/arm/xlnx-zynqmp.h.
Also:
hw/intc/gic* (ARM)
hw/*/mips* (MIPS)
hw/*/slavio* (SPARC)
libdecnumber/ (target-ppc/)
etc.
Any kind soul that converts the Coverity components into MAINTAINERS
patches?
Paolo
Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered, Cornelia Huck, 2016/08/30