[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] translate: early exit in tb_flush if there is n
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH] translate: early exit in tb_flush if there is no tcg |
Date: |
Thu, 25 Aug 2016 14:38:04 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 |
On 08/25/2016 02:11 PM, Christian Borntraeger wrote:
> tb_flush does all kind of things, which are very tcg specific. As it
> is called from some places even for KVM (e.g. gdb server) it is better
> to detect these cases and do an early exit.
> This also fixes a crash in the gdb server that was triggered by
> commit 909eaac9bbc2 ("tb hash: track translated blocks with qht").
>
Forgot to CC Peter.
> Suggested-by: Paolo Bonzini <address@hidden>
> Reported-by: Richard Henderson <address@hidden>
> Reported-by: Brent Baccala <address@hidden>
> Signed-off-by: Christian Borntraeger <address@hidden>
> ---
> translate-all.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/translate-all.c b/translate-all.c
> index efeba29..0dd6466 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -834,6 +834,9 @@ static void page_flush_tb(void)
> /* XXX: tb_flush is currently not thread safe */
> void tb_flush(CPUState *cpu)
> {
> + if (!tcg_enabled()) {
> + return;
> + }
> #if defined(DEBUG_FLUSH)
> printf("qemu: flush code_size=%ld nb_tbs=%d avg_tb_size=%ld\n",
> (unsigned long)(tcg_ctx.code_gen_ptr - tcg_ctx.code_gen_buffer),
>