[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC 2/6] migration: Report values for comparisons
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [RFC 2/6] migration: Report values for comparisons |
Date: |
Wed, 24 Aug 2016 14:42:29 +0100 |
From: "Dr. David Alan Gilbert" <address@hidden>
Report the values when a comparison fails; together with
the previous patch that prints the device and field names
this should give a good idea of why loading the migration failed.
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
migration/vmstate.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/migration/vmstate.c b/migration/vmstate.c
index 1d637b2..ec7fafc 100644
--- a/migration/vmstate.c
+++ b/migration/vmstate.c
@@ -557,6 +557,7 @@ static int get_int32_equal(QEMUFile *f, void *pv, size_t
size)
if (*v == v2) {
return 0;
}
+ error_report("%" PRId32 " != %" PRId32, *v, v2);
return -EINVAL;
}
@@ -580,6 +581,9 @@ static int get_int32_le(QEMUFile *f, void *pv, size_t size)
*cur = loaded;
return 0;
}
+ error_report("Invalid value %" PRId32
+ " expecting postiive value <= %" PRId32,
+ loaded, *cur);
return -EINVAL;
}
@@ -685,6 +689,7 @@ static int get_uint32_equal(QEMUFile *f, void *pv, size_t
size)
if (*v == v2) {
return 0;
}
+ error_report("%" PRIu32 " != %" PRIu32, *v, v2);
return -EINVAL;
}
@@ -727,6 +732,7 @@ static int get_uint64_equal(QEMUFile *f, void *pv, size_t
size)
if (*v == v2) {
return 0;
}
+ error_report("%" PRIu64 " != %" PRIu64, *v, v2);
return -EINVAL;
}
@@ -748,6 +754,7 @@ static int get_uint8_equal(QEMUFile *f, void *pv, size_t
size)
if (*v == v2) {
return 0;
}
+ error_report("%u != %u", *v, v2);
return -EINVAL;
}
@@ -769,6 +776,7 @@ static int get_uint16_equal(QEMUFile *f, void *pv, size_t
size)
if (*v == v2) {
return 0;
}
+ error_report("%u != %u", *v, v2);
return -EINVAL;
}
--
2.7.4
- [Qemu-devel] [RFC 0/6] converting some of virtio to VMState, Dr. David Alan Gilbert (git), 2016/08/24
- [Qemu-devel] [RFC 6/6] virtio/migration: Migrate virtio-net to VMState, Dr. David Alan Gilbert (git), 2016/08/24
- [Qemu-devel] [RFC 1/6] migration: report an error giving the failed field, Dr. David Alan Gilbert (git), 2016/08/24
- [Qemu-devel] [RFC 5/6] virtio/migration: Migrate balloon to VMState, Dr. David Alan Gilbert (git), 2016/08/24
- Re: [Qemu-devel] [RFC 0/6] converting some of virtio to VMState, Cornelia Huck, 2016/08/24