Re: [Qemu-devel] [PATCH for-2.7 2/2] net: make socket connect non-blocking again

[Marc-André Lureau]

Hi

----- Original Message -----
> On Tue, Aug 23, 2016 at 06:43:54PM +0800, Cao jin wrote:
> > Hi,
> > I just noticed you still using the old-style non-blocking connect(which
> > will
> > still block when query DNS), which will be removed (suggested by Daniel),
> > but the patch is still on the way. So I guess maybe you should switch to
> > QIOChannel way.
> > 
> > FYI:
> > http://lists.nongnu.org/archive/html/qemu-devel/2016-07/msg06386.html
> > http://lists.nongnu.org/archive/html/qemu-devel/2016-08/msg00046.html
> 
> Yes, switching to QIOChannel would be good, but that is certainly not
> something that's acceptable for 2.7.0. We need Marc-André's fix in the
> short term for this release. If someone wants to do a QIOChannel
> conversion for 2.8.0/2.9.0/etc that's an option...

After looking at this a bit, it would need significant effort for net/socket to 
switch fully to qiochannel, so it's certainly not for 2.7. However, we could 
use it just for the connect step for now (see attached patch)

(tbh, I am not sure how well that net/socket async code is being handled in 
case of cancellation etc..)

0001-net-make-socket-connect-non-blocking-again.patch
Description: Text Data