[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 5/6] virtio-balloon: drop ->stats_vq_offset
From: |
Roman Kagan |
Subject: |
[Qemu-devel] [PATCH v2 5/6] virtio-balloon: drop ->stats_vq_offset |
Date: |
Fri, 19 Aug 2016 16:39:24 +0300 |
As we don't write anything to guest on stats virtqueue we should pass
len=0 to virtqueue_push(). This makes ->stats_vq_offset unnecessary, so
drop it.
Signed-off-by: Roman Kagan <address@hidden>
Cc: "Michael S. Tsirkin" <address@hidden>
Cc: Ladi Prosek <address@hidden>
Cc: Stefan Hajnoczi <address@hidden>
---
hw/virtio/virtio-balloon.c | 3 +--
include/hw/virtio/virtio-balloon.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index f00ad8e..056ae49 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -92,7 +92,7 @@ static void balloon_stats_push_elem(VirtIOBalloon *s)
{
VirtIODevice *vdev = VIRTIO_DEVICE(s);
- virtqueue_push(s->svq, s->stats_vq_elem, s->stats_vq_offset);
+ virtqueue_push(s->svq, s->stats_vq_elem, 0);
virtio_notify(vdev, s->svq);
g_free(s->stats_vq_elem);
s->stats_vq_elem = NULL;
@@ -283,7 +283,6 @@ static void virtio_balloon_receive_stats(VirtIODevice
*vdev, VirtQueue *vq)
if (tag < VIRTIO_BALLOON_S_NR)
s->stats[tag] = val;
}
- s->stats_vq_offset = offset;
if (qemu_gettimeofday(&tv) < 0) {
fprintf(stderr, "warning: %s: failed to get time of day\n", __func__);
diff --git a/include/hw/virtio/virtio-balloon.h
b/include/hw/virtio/virtio-balloon.h
index d72ff7f..91b0138 100644
--- a/include/hw/virtio/virtio-balloon.h
+++ b/include/hw/virtio/virtio-balloon.h
@@ -38,7 +38,6 @@ typedef struct VirtIOBalloon {
uint32_t actual;
uint64_t stats[VIRTIO_BALLOON_S_NR];
VirtQueueElement *stats_vq_elem;
- size_t stats_vq_offset;
QEMUTimer *stats_timer;
int64_t stats_last_update;
int64_t stats_poll_interval;
--
2.7.4
- [Qemu-devel] [PATCH v2 0/6] virtio-balloon: assorted fixes, Roman Kagan, 2016/08/19
- [Qemu-devel] [PATCH v2 2/6] virtio-balloon: make stats virtqueue length 1, Roman Kagan, 2016/08/19
- [Qemu-devel] [PATCH v2 4/6] virtio-balloon: keep collecting stats on save/restore, Roman Kagan, 2016/08/19
- Re: [Qemu-devel] [PATCH v2 0/6] virtio-balloon: assorted fixes, Roman Kagan, 2016/08/19
- [Qemu-devel] [PATCH v2 5/6] virtio-balloon: drop ->stats_vq_offset,
Roman Kagan <=
- [Qemu-devel] [PATCH v2 6/6] virtio-balloon: drop reset handler, Roman Kagan, 2016/08/19
- [Qemu-devel] [PATCH v2 6/6] virtio-ballon: drop reset handler, Roman Kagan, 2016/08/19
- [Qemu-devel] [PATCH v2 3/6] virtio-balloon: don't restart stats timer in callback, Roman Kagan, 2016/08/19
- [Qemu-devel] [PATCH v2 1/6] virtio: assert on ->inuse underflow, Roman Kagan, 2016/08/19