[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] docker.py: don't hang on large docker outpu
From: |
Janosch Frank |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] docker.py: don't hang on large docker output |
Date: |
Fri, 19 Aug 2016 10:58:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 |
On 08/18/2016 10:12 PM, Sascha Silbe wrote:
> Unlike Popen.communicate(), subprocess.call() doesn't read from the
> stdout file descriptor. If the child process produces more output than
> fits into the pipe buffer, it will block indefinitely.
>
> If we don't intend to consume the output, just send it straight to
> /dev/null to avoid this issue.
>
> Signed-off-by: Sascha Silbe <address@hidden>
Reviewed-by: Janosch Frank <address@hidden>