[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5] fpu: add mechanism to check for invalid long
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v5] fpu: add mechanism to check for invalid long double formats |
Date: |
Thu, 18 Aug 2016 16:35:07 +0100 |
On 17 August 2016 at 01:14, Andrew Dutcher <address@hidden> wrote:
> All operations that take a floatx80 as an operand need to have their
> inputs checked for malformed encodings. In all of these cases, use the
> function floatx80_invalid_encoding to perform the check. If an invalid
> operand is found, raise an invalid operation exception, and then return
> either NaN (for fp-typed results) or the integer indefinite value (the
> minimum representable signed integer value, for int-typed results).
>
> For the non-quiet comparison operations, this touches adjacent code in
> order to pass style checks.
>
> Signed-off-by: Andrew Dutcher <address@hidden>
This version looks good -- thanks for your effort in working
through the code review process.
Reviewed-by: Peter Maydell <address@hidden>
and I'll make sure it gets committed once the trunk reopens
after the 2.7 release.
thanks
-- PMM