qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/6] e1000e: drop unnecessary funtions


From: Cao jin
Subject: Re: [Qemu-devel] [PATCH 4/6] e1000e: drop unnecessary funtions
Date: Thu, 18 Aug 2016 15:38:00 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0



On 08/18/2016 01:23 PM, Dmitry Fleytman wrote:


On 17 Aug 2016, at 17:39, Cao jin <address@hidden> wrote:

Internal helper function: e1000e_init_msix(), e1000e_cleanup_msix()
is unnecessary, remove them all.

Is there any reason to drop these functions?
They exist to improve code readability and modularisation.


previous commit 66bf7d58d removed the corresponding function of msi, so,
keep the consistency is the reason

--
Yours Sincerely,

Cao jin





reply via email to

[Prev in Thread] Current Thread [Next in Thread]