[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_m
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table. |
Date: |
Fri, 12 Aug 2016 18:47:42 +0300 |
On Fri, Aug 12, 2016 at 03:20:56AM -0400, Marc-André Lureau wrote:
> Hi
>
> ----- Original Message -----
> > sent a follow-up response to GET_FEATURES), I am now wondering if this patch
> > may break existing vhost applications too ? If so, reverting it possibly
> > better.
> > What confuses me is why it doesn’t fail all the time, but only about 20% to
> > 30% time as Fam reports.
> >
> > Thoughts : Michael, Fam, MarcAndre ?
>
> Indeed, I didn't ack that patch in the first place for that kind of reasons,
> so I would revert it.
>
> thanks
I guess that's the safest thing to do for 2.7.
At least that's not any worse than 2.6.
I still think it's a good idea long term and test should be fixed,
but let's revert for now.
--
MST
- [Qemu-devel] [PULL 0/3] virtio/vhost: fixes, Michael S. Tsirkin, 2016/08/10
- [Qemu-devel] [PULL 2/3] vhost-user: Introduce a new protocol feature REPLY_ACK., Michael S. Tsirkin, 2016/08/10
- [Qemu-devel] [PULL 1/3] vhost: check for vhost_ops before using., Michael S. Tsirkin, 2016/08/10
- [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Michael S. Tsirkin, 2016/08/10
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Fam Zheng, 2016/08/12
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Prerna Saxena, 2016/08/12
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Marc-André Lureau, 2016/08/12
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Peter Maydell, 2016/08/12
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Michael S. Tsirkin, 2016/08/12
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Peter Maydell, 2016/08/15
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Marc-André Lureau, 2016/08/12
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Michael S. Tsirkin, 2016/08/12
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Marc-André Lureau, 2016/08/13
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Michael S. Tsirkin, 2016/08/13
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Michael S. Tsirkin, 2016/08/13
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Michael S. Tsirkin, 2016/08/13
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Prerna Saxena, 2016/08/14
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Michael S. Tsirkin, 2016/08/14
- Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table., Maxime Coquelin, 2016/08/31
Re: [Qemu-devel] [PULL 0/3] virtio/vhost: fixes, Peter Maydell, 2016/08/10