Re: [Qemu-devel] [PATCH v2 01/27] atomics: add atomic_xor

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> From: "Emilio G. Cota" <address@hidden>
>
> This paves the way for upcoming work.
>
> Signed-off-by: Emilio G. Cota <address@hidden>
> Message-Id: <address@hidden>

Reviewed-by: Alex Bennée <address@hidden>

> ---
>  include/qemu/atomic.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h
> index 7a59096..a5531da 100644
> --- a/include/qemu/atomic.h
> +++ b/include/qemu/atomic.h
> @@ -161,6 +161,7 @@
>  #define atomic_fetch_sub(ptr, n) __atomic_fetch_sub(ptr, n, __ATOMIC_SEQ_CST)
>  #define atomic_fetch_and(ptr, n) __atomic_fetch_and(ptr, n, __ATOMIC_SEQ_CST)
>  #define atomic_fetch_or(ptr, n)  __atomic_fetch_or(ptr, n, __ATOMIC_SEQ_CST)
> +#define atomic_fetch_xor(ptr, n) __atomic_fetch_xor(ptr, n, __ATOMIC_SEQ_CST)
>
>  /* And even shorter names that return void.  */
>  #define atomic_inc(ptr)    ((void) __atomic_fetch_add(ptr, 1, 
> __ATOMIC_SEQ_CST))
> @@ -169,6 +170,7 @@
>  #define atomic_sub(ptr, n) ((void) __atomic_fetch_sub(ptr, n, 
> __ATOMIC_SEQ_CST))
>  #define atomic_and(ptr, n) ((void) __atomic_fetch_and(ptr, n, 
> __ATOMIC_SEQ_CST))
>  #define atomic_or(ptr, n)  ((void) __atomic_fetch_or(ptr, n, 
> __ATOMIC_SEQ_CST))
> +#define atomic_xor(ptr, n) ((void) __atomic_fetch_xor(ptr, n, 
> __ATOMIC_SEQ_CST))
>
>  #else /* __ATOMIC_RELAXED */
>
> @@ -355,6 +357,7 @@
>  #define atomic_fetch_sub       __sync_fetch_and_sub
>  #define atomic_fetch_and       __sync_fetch_and_and
>  #define atomic_fetch_or        __sync_fetch_and_or
> +#define atomic_fetch_xor       __sync_fetch_and_xor
>  #define atomic_cmpxchg         __sync_val_compare_and_swap
>
>  /* And even shorter names that return void.  */
> @@ -364,6 +367,7 @@
>  #define atomic_sub(ptr, n)     ((void) __sync_fetch_and_sub(ptr, n))
>  #define atomic_and(ptr, n)     ((void) __sync_fetch_and_and(ptr, n))
>  #define atomic_or(ptr, n)      ((void) __sync_fetch_and_or(ptr, n))
> +#define atomic_xor(ptr, n)     ((void) __sync_fetch_and_xor(ptr, n))
>
>  #endif /* __ATOMIC_RELAXED */
>  #endif /* __QEMU_ATOMIC_H */


--
Alex Bennée