[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 11/14] checkpatch: check for CVS keywords on all sour
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 11/14] checkpatch: check for CVS keywords on all sources |
Date: |
Wed, 10 Aug 2016 15:57:14 +0200 |
These should apply to all files, not just C/C++. Tweak the regular
expression to check for whole words, to avoid false positives on Perl
variables starting with "Id".
Signed-off-by: Paolo Bonzini <address@hidden>
---
scripts/checkpatch.pl | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 082c4ce..fea576d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1354,6 +1354,11 @@ sub process {
WARN("adding a line without newline at end of file\n" .
$herecurr);
}
+# check for RCS/CVS revision markers
+ if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|\b)/) {
+ WARN("CVS style keyword markers, these will _not_ be
updated\n". $herecurr);
+ }
+
# tabs are only allowed in assembly source code, and in
# some scripts we imported from other projects.
next if ($realfile =~ /\.(s|S)$/);
@@ -1368,11 +1373,6 @@ sub process {
# check we are in a valid C source file if not then ignore this hunk
next if ($realfile !~ /\.(h|c|cpp)$/);
-# check for RCS/CVS revision markers
- if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
- WARN("CVS style keyword markers, these will _not_ be
updated\n". $herecurr);
- }
-
# Check for potential 'bare' types
my ($stat, $cond, $line_nr_next, $remain_next, $off_next,
$realline_next);
--
1.8.3.1
- [Qemu-devel] [PULL 00/14] checkpatch, warnings and other fixes, Paolo Bonzini, 2016/08/10
- [Qemu-devel] [PULL 03/14] optionrom: add -fno-stack-protector, Paolo Bonzini, 2016/08/10
- [Qemu-devel] [PULL 04/14] optionrom: fix compilation with mingw docker target, Paolo Bonzini, 2016/08/10
- [Qemu-devel] [PULL 02/14] build-sys: fix building with make CFLAGS=.. argument, Paolo Bonzini, 2016/08/10
- [Qemu-devel] [PULL 01/14] linuxboot_dma: avoid guest ABI breakage on gcc vs. clang compilation, Paolo Bonzini, 2016/08/10
- [Qemu-devel] [PULL 05/14] atomic: strip "const" from variables declared with typeof, Paolo Bonzini, 2016/08/10
- [Qemu-devel] [PULL 06/14] Disable warn about left shifts of negative values, Paolo Bonzini, 2016/08/10
- [Qemu-devel] [PULL 07/14] clang: Fix warning reg. expansion to 'defined', Paolo Bonzini, 2016/08/10
- [Qemu-devel] [PULL 08/14] checkpatch: ignore automatically imported Linux headers, Paolo Bonzini, 2016/08/10
- [Qemu-devel] [PULL 11/14] checkpatch: check for CVS keywords on all sources,
Paolo Bonzini <=
- [Qemu-devel] [PULL 10/14] checkpatch: tweak the files in which TABs are checked, Paolo Bonzini, 2016/08/10
- [Qemu-devel] [PULL 09/14] timer: set vm_clock disabled default, Paolo Bonzini, 2016/08/10
- [Qemu-devel] [PULL 12/14] CODING_STYLE, checkpatch: update line length rules, Paolo Bonzini, 2016/08/10
- [Qemu-devel] [PULL 13/14] checkpatch: bump most warnings to errors, Paolo Bonzini, 2016/08/10
- [Qemu-devel] [PULL 14/14] checkpatch: default to success if only warnings, Paolo Bonzini, 2016/08/10
- Re: [Qemu-devel] [PULL 00/14] checkpatch, warnings and other fixes, Peter Maydell, 2016/08/10