qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.8 v1 11/60] trace: remove use of event ID


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH for-2.8 v1 11/60] trace: remove use of event ID enums from APIs
Date: Tue, 9 Aug 2016 18:26:49 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0


On 09/08/2016 18:24, Daniel P. Berrange wrote:
>>> > > -static inline TraceEventID trace_event_get_id(TraceEvent *ev)
>>> > > +static inline size_t trace_event_get_id(TraceEvent *ev)
>>> > >  {
>>> > >      assert(ev != NULL);
>>> > >      return ev->id;
>> > 
>> > Perhaps "unsigned" is a better match than size_t?
> I don't mind either way - I just happen to personally always use size_t
> for anything that ends up being used primarily as an array index.

Makes sense.  I was thinking of simpletrace's 32-bit id instead.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]