Re: [Qemu-devel] [PATCH v3 05/15] qapi: add 'export-marshal' command key

[Marc-André Lureau]

Hi

On Tue, Aug 9, 2016 at 12:07 PM Markus Armbruster <address@hidden> wrote:

> address@hidden writes:
>
> > From: Marc-André Lureau <address@hidden>
> >
> > When a command sets the 'export-marshal' key to true, the generated
> > marshaller will be exported, so it can be called from outside.
> >
> > Signed-off-by: Marc-André Lureau <address@hidden>
>
> Sure we need to make linkage configurable in the schema?  Why can't we
> simply make all the marshallers extern?
>

Why would you expose all marshallers if you don't have to? Also, they
shouldn't be called directly, but through qmp_dispatch() which does
preliminary checks. Alternatively, we could save the marshaller call:

return qobject_from_jsonf("{'QMP': {'version': {'qemu': "
                              "{'micro': %d. 'minor': %d, 'major': %d},"
                              "'package': '%s'}, "
                              "'capabilities': []}}",
                              QEMU_VERSION_MICRO, QEMU_VERSION_MINOR,
                              QEMU_VERSION_MAJOR, QEMU_PKGVERSION);


-- 
Marc-André Lureau