[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] clang: Disable warning about expansion to 'defi
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH] clang: Disable warning about expansion to 'defined' |
Date: |
Tue, 9 Aug 2016 09:13:31 +0100 |
User-agent: |
Mutt/1.6.2 (2016-07-01) |
On Tue, Aug 09, 2016 at 09:09:13AM +0100, Peter Maydell wrote:
> On 9 August 2016 at 03:35, Pranith Kumar <address@hidden> wrote:
> > Clang produces the following warning. The warning is detailed here:
> > https://reviews.llvm.org/D15866. Disable the warning.
> >
> > /home/pranith/devops/code/qemu/hw/display/qxl.c:507:5: warning: macro
> > expansion producing 'defined' has undefined behavior
> > [-Wexpansion-to-defined]
> > #if SPICE_NEEDS_SET_MM_TIME
> > ^
> > /home/pranith/devops/code/qemu/include/ui/qemu-spice.h:46:5: note: expanded
> > from macro 'SPICE_NEEDS_SET_MM_TIME'
> > (!defined(SPICE_SERVER_VERSION) || (SPICE_SERVER_VERSION < 0xc06))
> > ^
> > /home/pranith/devops/code/qemu/hw/display/qxl.c:1074:5: warning: macro
> > expansion producing 'defined' has undefined behavior
> > [-Wexpansion-to-defined]
> > #if SPICE_NEEDS_SET_MM_TIME
> > ^
> > /home/pranith/devops/code/qemu/include/ui/qemu-spice.h:46:5: note: expanded
> > from macro 'SPICE_NEEDS_SET_MM_TIME'
> > (!defined(SPICE_SERVER_VERSION) || (SPICE_SERVER_VERSION < 0xc06))
>
> Is this the only thing in our code which provokes the warning?
> If so, why don't we just fix it to not be undefined behaviour?
Indeed, it looks like it could be fixed by changing include/ui/qemu-spice.h
#define SPICE_NEEDS_SET_MM_TIME \
(!defined(SPICE_SERVER_VERSION) || (SPICE_SERVER_VERSION < 0xc06))
to be
#if !defined(SPICE_SERVER_VERSION) || (SPICE_SERVER_VERSION < 0xc06)
#define SPICE_NEEDS_SET_MM_TIME
#endif
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|