qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 03/15] monitor: register gen:false commands m


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v3 03/15] monitor: register gen:false commands manually
Date: Tue, 09 Aug 2016 09:52:08 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

address@hidden writes:

> From: Marc-André Lureau <address@hidden>
>
> Since a few commands are using 'gen': false, they are not registered
> automatically by the generator. Register manually instead.
>
> This is in preparation for removal of qapi 'middle' mode generation.
>
> Note that this function isn't run yet, until

"these functions aren't"

Can touch up on commit.

> module_call_init(MODULE_INIT_QAPI) is added in a later patch.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>  monitor.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/monitor.c b/monitor.c
> index cb1a0c7..c9191e5 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -79,6 +79,7 @@
>  #include "sysemu/block-backend.h"
>  #include "sysemu/qtest.h"
>  #include "qemu/cutils.h"
> +#include "qapi/qmp/dispatch.h"
>  
>  /* for hmp_info_irq/pic */
>  #if defined(TARGET_SPARC)
> @@ -1000,6 +1001,18 @@ static void qmp_query_qmp_schema(QDict *qdict, QObject 
> **ret_data,
>      *ret_data = qobject_from_json(qmp_schema_json);
>  }
>  
> +static void qmp_init_marshal(void)
> +{
> +    qmp_register_command("query-qmp-schema", qmp_query_qmp_schema,
> +                         QCO_NO_OPTIONS);
> +    qmp_register_command("device_add", qmp_device_add,
> +                         QCO_NO_OPTIONS);
> +    qmp_register_command("netdev_add", qmp_netdev_add,
> +                         QCO_NO_OPTIONS);
> +}
> +
> +qapi_init(qmp_init_marshal);
> +
>  /* set the current CPU defined by the user */
>  int monitor_set_cpu(int cpu_index)
>  {



reply via email to

[Prev in Thread] Current Thread [Next in Thread]