Re: [Qemu-devel] [PATCH v3 00/15] qapi: remove the 'middle' mode

[Marc-André Lureau]

On Mon, Aug 8, 2016 at 6:57 PM <address@hidden> wrote:

> Hi,
>
> Your series seems to have some coding style problems. See output below for
> more information:
>

While at it, I guess I could remove those trailing spaces too


>
> Message-id: address@hidden
> Type: series
> Subject: [Qemu-devel] [PATCH v3 00/15] qapi: remove the 'middle' mode
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
>
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
>
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
>     echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s
> $c)..."
>     if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback
> -; then
>         failed=1
>         echo
>     fi
>     n=$((n+1))
> done
>
> exit $failed
> === TEST SCRIPT END ===
>
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
>  * [new tag]         patchew/
> address@hidden -> patchew/
> address@hidden
> Switched to a new branch 'test'
> 3879f40 qmp-commands.txt: fix some styling
> f962de2 Drop qmp-commands.hx
> 69cf17d build-sys: remove qmp-commands-old.h
> fb249f9 monitor: use qmp_dispatch()
> ce3a886 qmp: update qmp_query_spice fallback
> e9443e9 qapi: check invalid arguments on no-args commands
> 6159f41 qapi: remove the "middle" mode
> 51a6744 monitor: implement 'qmp_query_commands' without qmp_cmds
> 48e462f monitor: remove mhandler.cmd_new
> 1705b2d monitor: register the qapi generated commands
> 82316cd qapi: add 'export-marshal' command key
> 3bd2e14 monitor: remove usage of generated marshal functions
> f283f5e monitor: register gen:false commands manually
> f9b1148 qapi-schema: add 'device_add'
> 53e5fc1 qapi-schema: use generated marshaller for 'qmp_capabilities'
>
> === OUTPUT BEGIN ===
> Checking PATCH 1/15: qapi-schema: use generated marshaller for
> 'qmp_capabilities'...
> Checking PATCH 2/15: qapi-schema: add 'device_add'...
> Checking PATCH 3/15: monitor: register gen:false commands manually...
> Checking PATCH 4/15: monitor: remove usage of generated marshal
> functions...
> Checking PATCH 5/15: qapi: add 'export-marshal' command key...
> Checking PATCH 6/15: monitor: register the qapi generated commands...
> Checking PATCH 7/15: monitor: remove mhandler.cmd_new...
> Checking PATCH 8/15: monitor: implement 'qmp_query_commands' without
> qmp_cmds...
> Checking PATCH 9/15: qapi: remove the "middle" mode...
> Checking PATCH 10/15: qapi: check invalid arguments on no-args commands...
> Checking PATCH 11/15: qmp: update qmp_query_spice fallback...
> Checking PATCH 12/15: monitor: use qmp_dispatch()...
> Checking PATCH 13/15: build-sys: remove qmp-commands-old.h...
> Checking PATCH 14/15: Drop qmp-commands.hx...
> ERROR: trailing whitespace
> #5128: FILE: qmp-commands.txt:73:
> +Arguments: $
>
> ERROR: trailing whitespace
> #6620: FILE: qmp-commands.txt:1565:
> +Arguments: $
>
> ERROR: trailing whitespace
> #7346: FILE: qmp-commands.txt:2291:
> +   $
>
> ERROR: trailing whitespace
> #7363: FILE: qmp-commands.txt:2308:
> +   $
>
> ERROR: trailing whitespace
> #7747: FILE: qmp-commands.txt:2692:
> +               (such as RDMA pinning) which may be expensive, but do not $
>
> ERROR: trailing whitespace
> #7748: FILE: qmp-commands.txt:2693:
> +               actually occur during the iterative migration rounds $
>
> total: 6 errors, 0 warnings, 3887 lines checked
>
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> Checking PATCH 15/15: qmp-commands.txt: fix some styling...
> === OUTPUT END ===
>
> Test command exited with code: 1

-- 
Marc-André Lureau