[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v6 1/4] blockdev: prepare iSCSI blo
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH v6 1/4] blockdev: prepare iSCSI block driver for dynamic loading |
Date: |
Mon, 8 Aug 2016 16:18:09 +0100 |
User-agent: |
Mutt/1.6.2 (2016-07-01) |
On Tue, Aug 02, 2016 at 10:12:14AM -0400, Colin Lord wrote:
> diff --git a/vl.c b/vl.c
> index e7c2c62..1a5f807 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -506,6 +506,41 @@ static QemuOptsList qemu_fw_cfg_opts = {
> },
> };
>
> +static QemuOptsList qemu_iscsi_opts = {
> + .name = "iscsi",
> + .head = QTAILQ_HEAD_INITIALIZER(qemu_iscsi_opts.head),
> + .desc = {
> + {
> + .name = "user",
> + .type = QEMU_OPT_STRING,
> + .help = "username for CHAP authentication to target",
> + },{
> + .name = "password",
> + .type = QEMU_OPT_STRING,
> + .help = "password for CHAP authentication to target",
> + },{
> + .name = "password-secret",
> + .type = QEMU_OPT_STRING,
> + .help = "ID of the secret providing password for CHAP "
> + "authentication to target",
> + },{
> + .name = "header-digest",
> + .type = QEMU_OPT_STRING,
> + .help = "HeaderDigest setting. "
> + "{CRC32C|CRC32C-NONE|NONE-CRC32C|NONE}",
> + },{
> + .name = "initiator-name",
> + .type = QEMU_OPT_STRING,
> + .help = "Initiator iqn name to use when connecting",
> + },{
> + .name = "timeout",
> + .type = QEMU_OPT_NUMBER,
> + .help = "Request timeout in seconds (default 0 = no timeout)",
> + },
> + { /* end of list */ }
> + },
> +};
> +
> /**
> * Get machine options
> *
> @@ -3001,6 +3036,9 @@ int main(int argc, char **argv, char **envp)
> qemu_add_opts(&qemu_icount_opts);
> qemu_add_opts(&qemu_semihosting_config_opts);
> qemu_add_opts(&qemu_fw_cfg_opts);
> +#ifdef CONFIG_LIBISCSI
> + qemu_add_opts(&qemu_iscsi_opts);
> +#endif
This will probably produce "unused variable" warnings and cause the
build to fail when CONFIG_LIBISCSI is not defined.
In this case I'd add an ifdef around qemu_iscsi_opts.
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v6 0/4] Dynamic module loading for block drivers, Colin Lord, 2016/08/02
- [Qemu-devel] [PATCH v6 2/4] blockdev: Add dynamic generation of module_block.h, Colin Lord, 2016/08/02
- [Qemu-devel] [PATCH v6 1/4] blockdev: prepare iSCSI block driver for dynamic loading, Colin Lord, 2016/08/02
- Re: [Qemu-devel] [Qemu-block] [PATCH v6 1/4] blockdev: prepare iSCSI block driver for dynamic loading,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v6 3/4] blockdev: Add dynamic module loading for block drivers, Colin Lord, 2016/08/02
- [Qemu-devel] [PATCH v6 4/4] blockdev: Modularize nfs block driver, Colin Lord, 2016/08/02
- Re: [Qemu-devel] [PATCH v6 0/4] Dynamic module loading for block drivers, Colin Lord, 2016/08/02