Re: [Qemu-devel] [PATCH for-2.7 v4 00/36] Various memory leak fixes

[Peter Maydell]

On 7 August 2016 at 20:31, Marc-André Lureau <address@hidden> wrote:
> Hi
>
> On Sun, Aug 7, 2016 at 11:15 PM Peter Maydell <address@hidden>
> wrote:
>>
>> On 5 August 2016 at 19:01, Marc-André Lureau <address@hidden>
>> wrote:
>> > Hi Peter,
>> >
>> > All patches have a reviewed-by tag now, Given the mix of domains, I can
>> > send
>> > you a pull request. What do you think?
>>
>> 36 patches is a lot to be landing on the eve of rc2. How many
>> of these are actual leaks rather than leaks in test cases
>> or things that are in theory leaks but of objects that
>> in practice last the life of the QEMU process anyway ?
>
>
> They should be fairly safe, but I don't mind moving it to after the release.
> Yes, many of the patches are one-time leaks and for tests.
>
> This would be a possible shortlist for 2.7 of things that could be more than
> one-timer though:
>
> numa: do not leak NumaOptions
> char: free the tcp connection data when closing
> char: free MuxDriver when closing
> ahci: free irqs array
> qjson: free str
> virtio-input: free config list
> usb: free USBDevice.strings
> usb: free leaking path
> ahci: fix sglist leak on retry

That looks like a much shorter list which I'd definitely
be happier with applying.

thanks
-- PMM