[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tests: Rename qtests which have names ending "e
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] tests: Rename qtests which have names ending "error" |
Date: |
Fri, 5 Aug 2016 16:39:42 +0100 |
On 4 August 2016 at 12:31, Daniel P. Berrange <address@hidden> wrote:
> On Thu, Aug 04, 2016 at 11:39:38AM +0100, Peter Maydell wrote:
>> We have three qtest tests which have test names ending with "error".
>> This is awkward because the output of verbose test runs looks like
>> /crypto/task/error: OK
>> /crypto/task/thread_error: OK
>>
>> which gives false positives if you are grepping build logs for
>> errors by looking for "error:". Since there are only three tests
>> with this problem, just rename them all to 'failure' instead.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>
> Reviewed-by: Daniel P. Berrange <address@hidden>
>
>> ---
>> Per discussion on IRC yesterday. I might throw this one into 2.7,
>> I dunno.
>
> It has no functional change, so low risk & thus fine to put in 2.7 IMHO
Applied to master, thanks.
-- PMM